feat: expand source provider resolution

crates/aim-cli/src/lib.rs

@@ -155,6 +155,47 @@ pub enum DispatchError {
     UpdateExecution(aim_core::app::update::ExecuteUpdatesError),
 }
 
+impl std::fmt::Display for DispatchError {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        match self {
+            Self::AddPlan(error) => match error {
+                aim_core::app::add::BuildAddPlanError::Query(
+                    aim_core::app::query::ResolveQueryError::Unsupported,
+                ) => write!(f, "unsupported source query"),
+                aim_core::app::add::BuildAddPlanError::NoInstallableArtifact { source } => write!(
+                    f,
+                    "no installable artifact found for {} {}",
+                    source.kind.as_str(),
+                    source.locator
+                ),
+                aim_core::app::add::BuildAddPlanError::Adapter(id, error) => match error {
+                    aim_core::adapters::traits::AdapterError::UnsupportedQuery => {
+                        write!(f, "{id} does not support this query")
+                    }
+                    aim_core::adapters::traits::AdapterError::UnsupportedSource => {
+                        write!(f, "{id} does not support this source")
+                    }
+                    aim_core::adapters::traits::AdapterError::ResolutionFailed(reason) => {
+                        write!(f, "{id} resolution failed: {reason}")
+                    }
+                },
+                aim_core::app::add::BuildAddPlanError::GitHubDiscovery(error) => {
+                    write!(f, "github discovery failed: {error:?}")
+                }
+                aim_core::app::add::BuildAddPlanError::NoCandidates => {
+                    write!(f, "no installable candidates found")
+                }
+            },
+            Self::AddInstall(error) => write!(f, "install failed: {error:?}"),
+            Self::Prompt(error) => write!(f, "prompt failed: {error:?}"),
+            Self::RemovePlan(error) => write!(f, "remove failed: {error:?}"),
+            Self::Registry(error) => write!(f, "registry failed: {error:?}"),
+            Self::UpdatePlan(error) => write!(f, "update planning failed: {error:?}"),
+            Self::UpdateExecution(error) => write!(f, "update execution failed: {error:?}"),
+        }
+    }
+}
+
 impl From<aim_core::app::add::BuildAddPlanError> for DispatchError {
     fn from(value: aim_core::app::add::BuildAddPlanError) -> Self {
         Self::AddPlan(value)

crates/aim-cli/src/main.rs

@@ -23,7 +23,7 @@ fn main() {
             }
         }
         Err(error) => {
-            eprintln!("{error:?}");
+            eprintln!("{error}");
             std::process::exit(1);
         }
     }

crates/aim-cli/tests/end_to_end_cli.rs

@@ -200,6 +200,103 @@ fn cli_add_installs_and_renders_resolved_mode() {
         .stdout(contains("Completed steps").not());
 }
 
+#[test]
+fn cli_add_installs_gitlab_source_with_truthful_origin() {
+    let dir = tempdir().unwrap();
+    let registry_path = dir.path().join("registry.toml");
+    let mut cmd = Command::cargo_bin("aim").unwrap();
+
+    cmd.arg("https://gitlab.com/example/team-app")
+        .env("AIM_REGISTRY_PATH", &registry_path)
+        .env(FIXTURE_MODE_ENV, "1")
+        .assert()
+        .success()
+        .stdout(contains("Installed team-app (user)"))
+        .stdout(contains("Source: gitlab https://gitlab.com/example/team-app"))
+        .stdout(contains(
+            "Artifact: https://gitlab.com/example/team-app/-/releases/permalink/latest/downloads/team-app.AppImage",
+        ));
+
+    let contents = std::fs::read_to_string(&registry_path).unwrap();
+    assert!(contents.contains("source_input = \"https://gitlab.com/example/team-app\""));
+    assert!(contents.contains("kind = \"GitLab\""));
+    assert!(contents.contains("locator = \"https://gitlab.com/example/team-app\""));
+    assert!(contents.contains("canonical_locator = \"example/team-app\""));
+}
+
+#[test]
+fn cli_add_preserves_direct_url_origin_for_provider_like_downloads() {
+    let dir = tempdir().unwrap();
+    let registry_path = dir.path().join("registry.toml");
+    let query = "https://sourceforge.net/projects/team-app/files/team-app-1.0.0.AppImage/download";
+    let mut cmd = Command::cargo_bin("aim").unwrap();
+
+    cmd.arg(query)
+        .env("AIM_REGISTRY_PATH", &registry_path)
+        .env(FIXTURE_MODE_ENV, "1")
+        .assert()
+        .success()
+        .stdout(contains("Installed "))
+        .stdout(contains(format!("Source: direct-url {query}")))
+        .stdout(contains(format!("Artifact: {query}")));
+
+    let contents = std::fs::read_to_string(&registry_path).unwrap();
+    assert!(contents.contains(&format!("source_input = \"{query}\"")));
+    assert!(contents.contains("kind = \"DirectUrl\""));
+    assert!(contents.contains(&format!("locator = \"{query}\"")));
+    assert!(!contents.contains("kind = \"SourceForge\""));
+}
+
+#[test]
+fn cli_add_installs_sourceforge_latest_download_with_truthful_origin() {
+    let dir = tempdir().unwrap();
+    let registry_path = dir.path().join("registry.toml");
+    let query = "https://sourceforge.net/projects/team-app/files/latest/download";
+    let mut cmd = Command::cargo_bin("aim").unwrap();
+
+    cmd.arg(query)
+        .env("AIM_REGISTRY_PATH", &registry_path)
+        .env(FIXTURE_MODE_ENV, "1")
+        .assert()
+        .success()
+        .stdout(contains("Installed team-app (user)"))
+        .stdout(contains(format!("Source: sourceforge {query}")))
+        .stdout(contains(format!("Artifact: {query}")));
+
+    let contents = std::fs::read_to_string(&registry_path).unwrap();
+    assert!(contents.contains(&format!("source_input = \"{query}\"")));
+    assert!(contents.contains("kind = \"SourceForge\""));
+    assert!(contents.contains(&format!("locator = \"{query}\"")));
+    assert!(contents.contains("canonical_locator = \"team-app\""));
+}
+
+#[test]
+fn cli_reports_unsupported_source_queries_distinctly() {
+    let dir = tempdir().unwrap();
+    let registry_path = dir.path().join("registry.toml");
+    let mut cmd = Command::cargo_bin("aim").unwrap();
+
+    cmd.arg("https://gitlab.com/example")
+        .env("AIM_REGISTRY_PATH", &registry_path)
+        .assert()
+        .failure()
+        .stderr(contains("unsupported source query"));
+}
+
+#[test]
+fn cli_reports_supported_sources_without_installable_artifacts_distinctly() {
+    let dir = tempdir().unwrap();
+    let registry_path = dir.path().join("registry.toml");
+    let mut cmd = Command::cargo_bin("aim").unwrap();
+
+    cmd.arg("https://sourceforge.net/projects/team-app/")
+        .env("AIM_REGISTRY_PATH", &registry_path)
+        .assert()
+        .failure()
+        .stderr(contains("no installable artifact found"))
+        .stderr(contains("sourceforge"));
+}
+
 #[test]
 fn cli_add_emits_live_progress_to_stderr() {
     let dir = tempdir().unwrap();